PR#537 - Directly open the details dialog

[Ranran(retired)]

The patch provides a way to open the details dialog directly.
The station or convoy panel of the list dialog opens the info dialog with a left click, but a CTRLShift-pressed click opens the details dialog directly.
The same applies to station numbers. EDIT: Also main view.

[Matthew]

Thank you for this contribution, Ranran. It's great to see you active again!

I think this is a great idea for a patch, so I compiled and tested it in pak128.Britain-Ex.

It works correctly in the Line Manager.   

However, when I Ctrl+Left-click on the map, then I get the Building Info Window.    For example, if I Ctrl+Left-click on a railway station tile, I get this:



I think this is correct behaviour, as it is a Simutrans convention that Ctrl+Left-click opens the Info Window that would usually be opened if you Left-clicked twice on that tile. However, I have to say that I almost never use this behaviour, but I expect that I would use direct access to the Details Window very often.

Maybe this feature is a better use of Ctrl+Left-click. Or maybe it should be changed to a different key? Maybe Right-click? I know Right-click is used for dragging the map; I don't know if it would be possible to separate clicking from dragging. Or maybe Alt+Left-click or something. Whatever is chosen should be the same in the Line Manager and the map, please.

Personally, I would also prefer the Details Window to open at the Services Tab, rather than the Passengers/mail Tab or Freight Tab, because I use the Service Tab more often. But IIRC we had this conversation before and you disagreed. I guess I need to learn to make my own patch for that! 

[jamespetts]

Perhaps shift+left click would be better for this feature so as not to clash with the feature of opening the building window? Thank you for your work on this in any event: it is certainly a worthwhile innovation.

[Ranran(retired)]

I'm late to report this, but the patch has already changed to shift+left click. (alt was currently unavailable due to lack of definition)
And the same access to the detail dialog is now available from the main screen.

I also found that specifying a tab to open is complicated and takes a lot of time because the tab index is not fixed in this dialog. Therefore I would not do it.

[jamespetts]

Excellent, thank you: now incorporated.