News:

Congratulations!
 You've won the News Item Lottery! Your prize? Reading this news item! :)

[ex-15] Can't edit the schedule

Started by Ranran, June 27, 2022, 09:18:41 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Ranran

When you close the schedule dialog, if it is sane, convoy will receive the changed schedule and will start working again, but now it will maintain an eternal "Schedule changing!" state when you close the dialog.

As reported in another thread this cannot be reproduced in last summer's ex-15 branch.

The following error log is emitted.
Message: nwc_tool_t::do_command:    id=24 init=1 defpar=g,113,5,0,0,0,1|2|170,19,4,0,0,0,1,1,42881,0,0,0,0,0,0|315,25,4,0,0,0,0,0,42882,0,0,0,0,0,0|414,6,4,0,0,0,0,0,42883,0,0,0,0,0,0|488,22,4,0,0,0,1,1,42884,0,0,0,0,0,0|414,7,4,0,0,0,0,0,42885,0,0,0,0,0,0|311,26,4,0,0,0,0,0,42886,0,0,0,0,0,0| flag=4
ERROR: schedule_t::sscanf_schedule():    incomplete string!



                if (schedule->sscanf_schedule(p) && scenario_check_schedule(welt, player, schedule, is_local_execution())) {
                    cnv->set_schedule(schedule);
                }
                else {
                    // could not read schedule, do not assign
                    delete schedule;
                }
In this part of simtool.cc, the above if statement should be executed, but the bottom is executed.
I wonder if the recent changes caused an error in the schedule structure.

jamespetts

Thank you for this - I believe that I have fixed this. I should be grateful if you could re-test.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.