Started by [C] Ranran, January 05, 2023, 06:04:12 PM
0 Members and 1 Guest are viewing this topic.
Quote from: jamespetts on January 14, 2023, 04:25:28 PMThank you for this. I have attempted to test this, but unfortunately get merge conflicts with the Ex-15 branch.
Quote from: jamespetts on January 18, 2023, 10:55:05 PMWhenever I click one of the column headers, I get an address sanitiser crash (complaining of use of deallocated memory) in line 227 of gui_container.cc.
QuoteEven when "show_side_view" is selected, the column header is still "name"
QuoteThe various status filters may need more thought: it is not obvious what the buttons do when they say "off" "12" "off" "off" "off" and "off".
QuoteAlso, for gameplay reasons, it is probably better to exclude the future button entirely.
Quote from: jamespetts on January 22, 2023, 11:00:15 AMAlso, even with show_future_vehicle_information = 0 set in the pakset's simuconf.tab, I still see vehicles far into the future when testing this in 1900
Quote from: jamespetts on January 22, 2023, 11:00:15 AMOn testing in the ex-15 branch
Quote from: [C] Ranran on January 22, 2023, 11:44:06 AMThank you for pointing this out. The judgment of show_future_vehicle_information was reversed. I think now I have fixed it.
QuoteDoes this mean the ex15-sortable-2 branch?I cannot reproduce this crash.
Quote from: jamespetts on January 22, 2023, 03:11:57 PMYes, that is the branch. I can still reproduce it. It only appears to occur on the second click on the column header, i.e., to sort ascending rather than descending. The error appears initially by way of an assert failure in the STD library when the code calls std::sort() in line 204 of gui_scrolled_list.cc - the error appears to be described as an invalid comparator error. Ignoring the assert failure leads to a crash in line 206 of gui_scrolled_list.cc.
Quote from: [C] Ranran on January 23, 2023, 09:09:45 AMThanks for the clarification. It looks like the problem below.https://stackoverflow.com/questions/32263560/errorinvalid-comparator-when-sorting-using-custom-comparison-functionI made a fix and would appreciate it if you could confirm that it avoids the crash.
Quote from: jamespetts on January 23, 2023, 07:28:46 PMThank you very much for this. Unfortunately, however, this does not appear to fix the problem - the original issue can be reproduced exactly as before.
Quote from: [C] Ranran on January 24, 2023, 11:20:30 AMI believe I have fixed this issue. Please confirm.
Quote from: [C] Ranran on January 05, 2023, 06:04:12 PMYou can test it on this branch.https://github.com/Ranran-the-JuicyPork/simutrans-exp/tree/2301-sortable-vehiclelist