PR#629 - Fixes for bugs and issues in classes feature

[Ranran]

I came back to do some unfinished work for simutrans extended.
However, it is temporary and I will not be submitting any new features. This is to fix any bugs or small issues I may have created.
Don't be like the shameless Japanese guy who impose his ego and ignore bugs. So I submit a patch for the issue listed below.

Known issue #1
Class translations are not handled correctly when a pakset has more than 6 classes.
This problem was once pointed out by James. I hadn't forgotten about it.
The patch was delayed because Ranran is very bad at handling memory in C++, so I thought I didn't have the skill to properly deal with changes in the number of arrays that need to be maintained.
I apologize for the delay in submitting the correction.

Known issue #2
The dot that displays the class rank in the vehicle list is currently fixed to yellow, resembling a star. However, this color may be difficult to see depending on the background of the theme. This should be controlled by the theme.

In the patch, you can change the colors by giving parameters to gui_color_class_insignia_dots for each theme.

See pull request #629 for these two changes.

[jamespetts]

I came back to do some unfinished work for simutrans extended.
However, it is temporary and I will not be submitting any new features. This is to fix any bugs or small issues I may have created.
Don't be like the shameless Japanese guy who impose his ego and ignore bugs. So I submit a patch for the issue listed below.

Known issue #1
Class translations are not handled correctly when a pakset has more than 6 classes.
This problem was once pointed out by James. I hadn't forgotten about it.
The patch was delayed because Ranran is very bad at handling memory in C++, so I thought I didn't have the skill to properly deal with changes in the number of arrays that need to be maintained.
I apologize for the delay in submitting the correction.

Known issue #2
The dot that displays the class rank in the vehicle list is currently fixed to yellow, resembling a star. However, this color may be difficult to see depending on the background of the theme. This should be controlled by the theme.

In the patch, you can change the colors by giving parameters to gui_color_class_insignia_dots for each theme.

See pull request #629 for these two changes.

Thank you very much - now incorporated.