News:

Simutrans Sites
Know our official sites. Find tools and resources for Simutrans.

PR #634 - fixes minor bugs and visibility improvements in the schedule list

Started by Ranran(retired), February 10, 2024, 12:12:02 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Ranran(retired)

Pull request #634 fixes minor bugs and visibility improvements in the schedule list dialog

- Fixed an issue where the number of waiting cargoes at the stop displayed sometimes overlapped on the "stops" tab.
- Improved visibility of waiting cargo table.
- Improved readability of bottom left part of the dialog.
- In languages such as English, the width was sometimes too wide, making it difficult to read the text.
I changed the text to solve that issue.

EDIT:
Fixed an error in the patch
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

Ranran(retired)

I also noticed a display bug with unfinished schedules that only have one station.
I've added a fix for it.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Ranran(retired)

It seems that the master branch contains an incomplete feature that is being tested.
I was trying to add the ability to split classes in the stops tab of the schedule list, but this is not working correctly on the master branch.
This feature is currently being further enhanced in a separate branch.
I would have to submit it.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

Quote from: Ranran(retired) on February 16, 2024, 05:40:04 PMIt seems that the master branch contains an incomplete feature that is being tested.
I was trying to add the ability to split classes in the stops tab of the schedule list, but this is not working correctly on the master branch.
This feature is currently being further enhanced in a separate branch.
I would have to submit it.
Thank you for clarifying. From what I can see, the incomplete feature does not at this stage cause any problems beyond not itself working.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

jamespetts

When testing the new feature in pull request no. 636, I noticed a slight issue with the transportation density display in the schedule window, which appears to have been introduced with this feature: when there is an overcrowded capacity, the left pane has a horizontal scroll bar no matter the size of the window. See here for a demonstration:

Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Ranran(retired)

Thank you for confirming.


For reference, if check the Linemanagement dialog in GUI debug mode, you can see that it has a layout like this.

GUI debug mode is to enable #define SHOW_BBOX.
This allows us to see what the layout looks like.
Simutrans' UI often has no borders and text appears to be floating randomly, so it can be difficult to understand what the structure is.



The left part of this dialog is actually divided into two parts, the top and bottom, and the part focused in red forms one block at the bottom, which will display a scroll bar if it doesn't fit within the frame.
The issue you pointed out is caused by the fact that the text in a particular cell inside the bottom left component is long, making the overall width wider.
This means that the "Overcrowded capacity" text is too long, increasing the overall size and creating a lot of dead space that makes the overall layout look unsightly.

In other words, the text for "Overcrowded capacity" is too long compared to the class name and goods name.
This sort of issues may occur in certain languages.

I think the simplest way to solve the issue is to not display the string "Overcrowded capacity" so that players can understand that it is an overcrowded capacity display.

Currently, Overcrowded capacity is distinguished by a thinner bar and since all Overcrowded capacities are grouped together and separated from classes, I think a good solution would be to divide this and combine it with each class.

The width of the Last month cell is wide because the UI system automatically adjusts the layout of the entire red frame.
This can be resolved by adding a blank space to the right end of the Monthly transportaion table.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

Ranran(retired)


As shown in the image, overcrowded capacity may exist in multiple classes. Therefore, I would like to eliminate the "Overcrowded capacity" string by linking the overcrowded capacity display to a class instead of merging them together.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

Ranran(retired)



Pull request #638 removes the "Overcrowding capacity" text from the loading/capacity indicator and makes changes to streamline the UI.

Also this may lead to solving the underlying issue.

(1) As A.Carrotti pointed out earlier, classes are distinguished by wealth, fare, and accommodation.
Overcrowded capacity is also closely related to fare class and accommodation. There seemed to be some contradictions there.
Until now, this relationship has been ambiguous.
Overcrowded capacity was lumped together, but this is clearly tied to classes.
For example, convoys and lines may have overcrowded capacity in separate classes, as in the example in the image above.

I hope you can confirm that these changes work as intended.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

wlindley

This looks excellent, on top of all the other recent updates thank you for making such a huge difference in playability!