PR #634 - fixes minor bugs and visibility improvements in the schedule list

[Ranran]

Pull request #634 fixes minor bugs and visibility improvements in the schedule list dialog

- Fixed an issue where the number of waiting cargoes at the stop displayed sometimes overlapped on the "stops" tab.
- Improved visibility of waiting cargo table.
- Improved readability of bottom left part of the dialog.
- In languages such as English, the width was sometimes too wide, making it difficult to read the text.
I changed the text to solve that issue.

EDIT:
Fixed an error in the patch

[Ranran]

I also noticed a display bug with unfinished schedules that only have one station.
I've added a fix for it.

[jamespetts]

Excellent, thank you. Now incorporated.

[Ranran]

It seems that the master branch contains an incomplete feature that is being tested.
I was trying to add the ability to split classes in the stops tab of the schedule list, but this is not working correctly on the master branch.
This feature is currently being further enhanced in a separate branch.
I would have to submit it.

[jamespetts]

It seems that the master branch contains an incomplete feature that is being tested.
I was trying to add the ability to split classes in the stops tab of the schedule list, but this is not working correctly on the master branch.
This feature is currently being further enhanced in a separate branch.
I would have to submit it.

Thank you for clarifying. From what I can see, the incomplete feature does not at this stage cause any problems beyond not itself working.

[jamespetts]

When testing the new feature in pull request no. 636, I noticed a slight issue with the transportation density display in the schedule window, which appears to have been introduced with this feature: when there is an overcrowded capacity, the left pane has a horizontal scroll bar no matter the size of the window. See here for a demonstration:

[Ranran]

Thank you for confirming.


For reference, if check the Linemanagement dialog in GUI debug mode, you can see that it has a layout like this.

GUI debug mode is to enable #define SHOW_BBOX.
This allows us to see what the layout looks like.
Simutrans' UI often has no borders and text appears to be floating randomly, so it can be difficult to understand what the structure is.



The left part of this dialog is actually divided into two parts, the top and bottom, and the part focused in red forms one block at the bottom, which will display a scroll bar if it doesn't fit within the frame.
The issue you pointed out is caused by the fact that the text in a particular cell inside the bottom left component is long, making the overall width wider.
This means that the "Overcrowded capacity" text is too long, increasing the overall size and creating a lot of dead space that makes the overall layout look unsightly.

In other words, the text for "Overcrowded capacity" is too long compared to the class name and goods name.
This sort of issues may occur in certain languages.

I think the simplest way to solve the issue is to not display the string "Overcrowded capacity" so that players can understand that it is an overcrowded capacity display.

Currently, Overcrowded capacity is distinguished by a thinner bar and since all Overcrowded capacities are grouped together and separated from classes, I think a good solution would be to divide this and combine it with each class.

The width of the Last month cell is wide because the UI system automatically adjusts the layout of the entire red frame.
This can be resolved by adding a blank space to the right end of the Monthly transportaion table.

[Ranran]

As shown in the image, overcrowded capacity may exist in multiple classes. Therefore, I would like to eliminate the "Overcrowded capacity" string by linking the overcrowded capacity display to a class instead of merging them together.

[Ranran]

Pull request #638 removes the "Overcrowding capacity" text from the loading/capacity indicator and makes changes to streamline the UI.

Also this may lead to solving the underlying issue.

(1) As A.Carrotti pointed out earlier, classes are distinguished by wealth, fare, and accommodation.
Overcrowded capacity is also closely related to fare class and accommodation. There seemed to be some contradictions there.
Until now, this relationship has been ambiguous.
Overcrowded capacity was lumped together, but this is clearly tied to classes.
For example, convoys and lines may have overcrowded capacity in separate classes, as in the example in the image above.

I hope you can confirm that these changes work as intended.

[wlindley]

This looks excellent, on top of all the other recent updates thank you for making such a huge difference in playability!