[BUG] Crash when using "Upgrade"

[Bittereinder]

Hello,

Version used:

- Latest nightly build 17/02/2024
- Pakset: Pak128.Britain-Ex

Reproduction:

- Go to "Line Management"
-> Select your Line
-> "Replace vehicles"
-> Select "Upgrade" in the Vehicles drop down lis
-> Crash to desktop.

Video: https://www.youtube.com/watch?v=BdcaGJbszA4

I had the same issues with trains as with buses.

This does NOT occur when sending the individual train to the depot manually and using "Upgrade" in the depot.

[Ranran]

Thank you for reporting the bug and apologize for the inconvenience.
However, it will definitely improve the quality of the game.

On first impression I wonder if this dialog should have sell options.
I think it is necessary to review related processing...

[Ranran]

I fixed the crashing bug. Please check pull request #637.

Also, unrelated to this issue, I have confirmed that the upgrade operation in the replace dialog is broken, and the upgrade will not be performed correctly.

I need to look into this.

EDIT:
Also a bug where upgrade was not performed correctly in the replace dialog has been fixed.
However, strangely it requires two clicks. For some reason the first click doesn't respond....

[Bittereinder]

I fixed the crashing bug. Please check pull request #637.

Also, unrelated to this issue, I have confirmed that the upgrade operation in the replace dialog is broken, and the upgrade will not be performed correctly.

I need to look into this.

EDIT:
Also a bug where upgrade was not performed correctly in the replace dialog has been fixed.
However, strangely it requires two clicks. For some reason the first click doesn't respond....

This is my first time bug reporting.

1) How do I test this? Do I have to wait for tonight's nightly build?

2) I have also noticed that the upgrade icon was not disappearing after upgrading a VEHICLE (bus) through the Line Management window. Perhaps this is the unrelated bug you are talking about. As far as I understand the game, this is the most up to date version of the bus in my 1925 game:

[jamespetts]

Excellent, thank you for (1) the report; and (2) the fix. Now incorporated.