Feedback on "Upgrade" fix

[Bittereinder]

Hi,

Original topic:
https://forum.simutrans.com/index.php/topic,22803.0.html

1) I have tested this and the game no longer crashes after clicking on "Upgrade" after using "Line Management" and "Replace Vehicles".

2) I did notice some unintended behaviour: there's an upgrade available for my vehicle (train), but when using the "Replace Vehicle" menu and "Upgrade" through "Line Management " it does NOT show me the available upgrade. When I send the train to the depot manually, it SHOWS me the available upgrade.

https://i.imgur.com/sjR8X2e.png

[Ranran]

I think you may not understand the upgrade steps correctly.
However, it may be because the upgrade procedure is not intuitive.

It is efficient to design a UI based on simutrans-standard design, and creating a unique UI requires a lot of effort.
Extensions may be provided within such constraints.

The replace dialog is desingned by reusing the depot dialog.
Thus the upgrade operation also requires the same steps as the depot dialog.

That is, the original vehicle must be included in the vehicle list "To be replaced by:"
But in the image you showed no vehicle is selected.
It is correct that no vehicle is selected in the initial state.
You need to assemble a replacing convoy from scratch using the same steps as purchasing a vehicle at a depot.


There are two ways to replace a vehicle in line
A. How to press the Replace vehicles button from the Line management dialog
B. How to select a specific convoy, access the convoy replacing dialog from there, and issue a command to execute the same replacement content edited there on all convoys in the line.

What you are trying to do is method A, but if you want to upgrade an existing vehicle by replacing, I recommend method B.



Open the replacing dialog from the convoy information dialog.

- Check that the upgradeable icon is displayed on the vehicle in (1)
- switch to upgrade mode
- Vehicles that can be upgraded from the vehicles in the list of new convoys to be replaced will be listed as shown in (3).
- If you want to apply this change to another convoy belonging to the line, change the replacing target in option (2)