News:

Simutrans.com Portal
Our Simutrans site. You can find everything about Simutrans from here.

r11240 - add player ranking

Started by Andarix, May 26, 2024, 06:39:46 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Andarix

new files missing

Quote...
2024-05-26T18:28:53.4119116Z /home/runner/work/simutrans/simutrans/src/simutrans/gui/simwin.cc:77:10: fatal error: player_ranking_frame.h: No such file or directory
2024-05-26T18:28:53.4121327Z    77 | #include "player_ranking_frame.h"

prissi

Oh indeed, that is still sitting on my laptop at home ... So it will need another 10 hours to be fixed.

Andarix

#2
r11242

linux
Quote...
2024-05-27T13:59:21.5563270Z /usr/bin/ld: CMakeFiles/simutrans.dir/src/simutrans/gui/simwin.cc.o: in function `rdwr_all_win(loadsave_t*)':
2024-05-27T13:59:21.5565308Z simwin.cc:(.text+0x30df): undefined reference to `player_ranking_frame_t::player_ranking_frame_t(unsigned char)'
2024-05-27T13:59:21.5567091Z /usr/bin/ld: CMakeFiles/simutrans.dir/src/simutrans/tool/simmenu.cc.o: in function `dialog_player_ranking_t::init(player_t*)':
2024-05-27T13:59:21.5568586Z simmenu.cc:(.text._ZN23dialog_player_ranking_t4initEP8player_t[_ZN23dialog_player_ranking_t4initEP8player_t]+0x21): undefined reference to `player_ranking_frame_t::player_ranking_frame_t(unsigned char)'
2024-05-27T13:59:21.5569821Z collect2: error: ld returned 1 exit status
2024-05-27T13:59:21.5572399Z make[2]: *** [CMakeFiles/simutrans.dir/build.make:5770: simutrans/simutrans] Error 1

windows compile

Ranran

The latest update to player rankings eliminates the term "Last year's ranking" by making it possible to select any year using a combo box instead of fixing it to one year ago. However, it is unclear whether standard will incorporate the changes.

Andarix

The text is there, but the selection field is missing.

Screenshot 2024-05-28 055812.png

prissi

@Andarix
Thanks for the update of the translations.

@Ranran
I had a hard time figure out why the order in my testgames did not work until I saw that one needs a sin64 for the comparison to avoid overflows ... I added the year selection manually since I was not sure from which branch to look at your many branches.

Andarix


Ranran

#7
Quote from: prissi on May 28, 2024, 05:56:51 AMI was not sure from which branch to look at your many branches.
here it is
https://github.com/Ranran-the-JuicyPork/simutrans-ex-fix/tree/2405-UI-player-ranking-v2

After making some modifications, I will need to change the file name and function name to the same as standard.

Quote from: Andarix on May 28, 2024, 03:59:15 AMScreenshot 2024-05-28 055812.png
I noticed that it doesn't take into account left_to_right_graphs setting. (´・ω・`)

The idea for this graph and ranking layout was stolen from a Mahjong League point progression chart.


Chart transitions and final results must be continuous.

So the reverse graph should look like this.



However, with the addition of year selection, that theory is no longer completely consistent... (´・ω・`)
Having said that, I think the results from a year ago are the most important, so I think it's better.

prissi

I wonder if the arrangement with the graph to the right is not nice to the eyes. Also standard lacks quite a few statistics extended has, so my version is necessarily poorer in functionality.

Also, I thought to add some vanity like the records (after saving them inside the game to avoid them constantly reoccurring after each reload.) And probably should achievement, should we decide to do any single game related achievements.