Started by felo, March 10, 2010, 05:48:22 PM
0 Members and 1 Guest are viewing this topic.
Quote from: eipi on July 08, 2012, 12:53:32 PM@prissi / Dwachs: Can you please make dots at the end of the first sentence? I run doxygen with JAVADOC_AUTOBRIEF which interprets the first sentence until the first dot in a comment as the brief description. It looks a bit weird in the generated documentation.
Quote from: An_dz on September 01, 2013, 10:58:48 PMI fixed some typos and translated some German in the gui folder.I also removed one duplicated include in welt.cc.
Quote from: An_dz on September 03, 2013, 05:13:16 PMPatches for docs, display and vehicle folders.
Quote from: Dwachs on September 04, 2013, 07:47:23 AMThank you! In r 6671. You fixed some prety epic typos.
Quote from: Dwachs on September 04, 2013, 07:47:23 AMNow in r6672 & r6673
Quote from: Dwachs on September 05, 2013, 07:47:13 AMThe best typo was: cooledcted -> collected. And not to forget: crossong, where somebody suggested cross-song
Quote from: kierongreen on September 01, 2013, 11:11:27 PMNice work - only reason I'm not going to patch this just now is that there's the GUI Theme Patch being developed at the moment and I fear this would probably conflict in a few places...
Quote from: kierongreen on September 17, 2013, 04:53:02 PMThat's a lot of translations! Some I think are great (zustand to cur_state for example, although I'd actually probably just use state) others I'm not so sure of. weg to way and str to road for example - I think if we are doing this then possibly we should consider translating class names as well to make sure code is consistent.
Quote from: Markohs on September 18, 2013, 02:27:34 PMI think he moved the comments to the .h, that's the place they should be
Quote from: Markohs on September 18, 2013, 04:06:46 PMWell, we decided to do it that way months ago, you could also say you don't like to browse .cc files when you are just looking at the .h of a class. no?
Quote from: Markohs on September 18, 2013, 11:26:44 PMAll open source projects have reached a agreement.
Quote from: prissi on September 19, 2013, 10:27:00 AMProperly documented sourcecode is not a waste of time. But this goes beyond writing just a oneliner what a function will do (which was for instance a lot of the 3.6.x OpenTTD sourcecode).
Quote from: prissi on September 19, 2013, 10:27:00 AMAnd as said before, this is open source. I committed in the past stuff I did not like and will do it in the future. I am not happy to be a "leader". I voice my option and then you can either commit or not.
Quote from: prissi on September 19, 2013, 10:27:00 AMMany of the 90ies technology in simutrans is due to Simutrans actually made in the 90ies. Until five year ago half of the files were C files, so you could not use variable definitions but at the top of the function. It took a month to have a full working version with *.cc files.
Quote from: prissi on September 19, 2013, 10:27:00 AMHence a lot of global, because of C. Nowadays the number of globals is much less.
Quote from: prissi on September 19, 2013, 10:27:00 AMAbout half of the code has its origin by people who never had any formal education in programming techniques (or none at all, like me). Furthermore, programming techniques are changing all the time. If you want your code only for specialist, use complex structures. You want as many people to have at least a chance to follow: Avoid too complex stuff, or less portable (not every platform has the latest compilers). I think you would agree on that.
Quote from: prissi on September 19, 2013, 10:27:00 AMSo what is complex: Some stuff makes code difficult to follow. For me many short functions are more difficult (I think kieron said something like this too) while you prefer many short ones. Namespaces are tricky because they may or may not overlay functions (same as operators). Otherwise they just add more letters, but if this helps understanding ... It never came really up.
Quote from: prissi on September 19, 2013, 10:27:00 AMvirtual functions can make the code much cleaner and hence easier, so it is preferred if you use them together with inheritance and unknown stuff. ding_T is a classical implementation of inheritance and virtual functions, or?
Quote from: prissi on September 19, 2013, 10:27:00 AMDoes "multiple responsabilities" means reusing code? When did this became a bad thing?
Quote from: prissi on September 19, 2013, 10:27:00 AMRefactoring is not bad, although not trivial. If trivial do it. (Or do you mean beautifying? I would like to do this today, but then experimental might get impossible to merge, even if it does the same. patches could be applied and then beautified.)