[r3453] powerlines give more income in fast-forward mode

[yobbobandana]

I noticed this using pak128. With pak64 power generation income was tiny compared to transport income so it was harder to tell the difference, but the same thing appeared to be happening.

When using fast-forward mode, power generation gives approimately twice the income that it does at normal speed.

Manually tweaking the speed using "," and "." didn't seem to change the income rate, just using the fast-forward button.

I set up a map where most of my income was from power generation and did two-months fast-forward, two months normal to highlight the difference, here's the finance chart (oprating profit = white, powerline income = green).

The only difference in the peaks is that I was using fast-forward.

[TurfIt]

I can't duplicate this. Can you make your test map available somewhere?

[neroden]

Ohhhh.... there are all kinds of funny timing issues in the power supply code.... this is going to be tedious to identify.

[yobbobandana]

I tried to upload the save to files.simutrans-germany.com before but it didn't work at all :(. I can try to find some file hosting somewhere for it if the pak128 test save will help.

(I haven't looked into the powerline code at all myself, don't really know where to start)

[knightly]

@Yobbobandana

You may try us (site down, do not visit) ]/]http://files.[ simutrans [dot] us (site down, do not visit) ]/.

[yobbobandana]

Thanks

Here is the file:
http://files.[ simutrans [dot] us (site down, do not visit) ]/files/get/WHVI7L57Lp/pak128-income-dependant-on-simulation-speed.sve

[TurfIt]

Patch attached. Powerline payments should be based on energy delivered rather than power. My powerline stabilisation patch changed the base calculations from energy to power but neglected the impact on the payment  .

[yobbobandana]

I can confirm that the issue is fixed with this patch applied.

I miss the astronomical powerline income a little though