The International Simutrans Forum

 

Author Topic: another buffer overflow in gui/depot_frame.cc  (Read 1542 times)

0 Members and 1 Guest are viewing this topic.

Offline ansgar

  • *
  • Posts: 80
another buffer overflow in gui/depot_frame.cc
« on: May 05, 2011, 10:32:25 PM »
Hi,

after I applied the patch for the buffer overflow in [1], I found another one due to txt_convoi_value also being to small.  This caused another crash when building with hardening flags and choosing Russian.

Please consider applying the attached patch.

Regards,
Ansgar

[1] http://forum.simutrans.com/index.php?topic=7231.0
« Last Edit: May 06, 2011, 01:53:15 AM by IgorEliezer »

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10662
  • Languages: De,EN,JP
Re: another buffer overflow in gui/depot_frame.cc
« Reply #1 on: May 06, 2011, 12:20:48 PM »
Increase, but imho this should be changed to money2string and buffer to avoid furhter bufffer overflows ...