[Patch] Filter vehicles list in depot to those relevant to current game

[falconne]

This patch allows you to filter the list of vehicles in the depot purchase panel to only those that are relevant to carrying the goods available in the current game. It builds on my previous patch to filter the goods list to show only goods being produced by factories in the current game.


Filtering only applies to objects that actually carry something. Locomotives, truck cabs, etc never get filtered.



The "Relevant" filter is on by default. You can also select specific goods from the list to only show vehicles capable of carrying that specific good. Prissi mentioned in the previous thread this might be too much... if needed I can remove this ability and just have a single checkbox that filters to relevant vehicles. The reason I did it this way was then when I first started playing, I found it a bit annoying that when I went to build a vehicle, I then had to open the goods list to find out what the category of the cargo was, then look for a capable vehicle in the list. This is probably not an issue for experienced players, but as a new player, when I go to build a vehicle I should not have to open another screen for cross reference.


If I don't filter by goods, I could perhaps get the same result by expanding the vehicle info text displayed when you hover over a vehicle, to also show the goods it can carry (from the currently available goods). How does that sound?

[Dwachs]

Good idea! I prefer filtering by goods over tooltips.

[Severous]

I like all your gameplaying patches falconne.

Can I check one thing. A factory only produces goods once there is a valid route in place.  If the vehicles do not show up until a factory produces...will we ever be able to set up new routes?

[falconne]

Can I check one thing. A factory only produces goods once there is a valid route in place.  If the vehicles do not show up until a factory produces...will we ever be able to set up new routes?

This won't be a problem. The goods filter builds up a list of all the goods that the factories on the map are capable of producing, regardless of whether they are being produced right now or not. So there shouldn't be any reason to build any of the vehicles that are filtered out... but if you wanted to see what else was available, you can just set the filter to "All" and it shows everything.

[Dwachs]

I can't download the patch, firefox wants to save index.php directly

[falconne]

I can't download the patch, firefox wants to save index.php directly

Hmm that's odd. It works for me, downloading with both Chrome and IE (I haven't got Firefox on this machine). Can't imagine what's going on there... I just included the patch file as an attachment as normal. Can you download other patches with Firefox?

[VS]

Argh, not that index.php meta-discussion again...

Right click and save as. The data come good, only lack a header with file name.

[Isaac Eiland-Hall]

Yes, the data of the file is correct, just rename from index.php --> proper filename

I believe it's caused by Firefox being slightly more strict in an interpretation than SMF. I'd rather not dwell on where the fault lies; it's annoying; but will be fixed, and hey, free software.

[falconne]

So this one's still sitting in "considered" status. Is that because the filter is a drop down that includes goods and not a checkbox for relevant vehicles only? I still think filtering by good is required, because having to open another dialog then look for applicable vehicles by mousing over them is not user friendly for a casual player.

[Dwachs]

No problem with the patch I think it is fine. I would like to change that goods in the drop down list are sorted alphabetically

Edit: incorporated in r5033.

[falconne]

Ah right yeah, good point. I'll fix that in a future patch.

[prissi]

I would suggest to keep the tab position, and just disable an empty tab. That way, one would not have jumping around of tabs when changing between different goods.