bug in r5358 - only first factory rotation used

[VS]

Original report: When city growth spawns a new end consumer, it is built always in first rotation, if it has even size (NxN). This does not happen if the industry is constructed manually.

If I read the code right...
1) The hierarchy of calls responsible for this is fabrikbauer_t::baue_hierarchie and then platzsucher_t::suche_platz.
2) Rotations after the first two are ignored entirely? (Rotation is passed as bool :-/ )
3) This happens only for factories in city, that are constructed by game itself. But not only end consumers.

[Dwachs]

It seems that standard orientation is prefered by the implementation.

[Dwachs]

here is a patch.

[VS]

Tested, and it seems to work as intended. Thanks! Of course only the first two rotations are selected, but one can't want everything handed on a silver plate...

[Dwachs]

If there are 4 possible rotations, then also all 4 rotations can be build. In my tests with pak128.Britain, factories in all 4 rotations were generated.

[VS]

ARGH, I have been fooled! The pak I got as a test for 4 rotations contained only two I guess this is solved

[Iver]

My bad 

[Dwachs]

in r5681.