News:

Simutrans.com Portal
Our Simutrans site. You can find everything about Simutrans from here.

wrong usage of PUSH_CLIP() in gui_tab_panel_t.

Started by wackdone, July 11, 2012, 06:38:15 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

wackdone

argument 'height' for macro PUSH_CLIP() is wrong in gui_tab_panel_t::zeichnen().
4th argument of PUSH_CLIP() must be height of clipping region, not the bottom point of the region.

(Incidentally, 'xx' is correct width of the tabs region. It's right for 3rd argument of PUSH_CLIP()).

Current code of the zeichnen() doesn't draw anything below HEADER_VSIZE.
Therefore, nothing would happen by this mistake.

It's not urgent. It will not immediately change anything in view of the game.

prissi


wackdone

Thanks for checking.
I think so, it should be fixed before any trouble.