Removing ground where convoy stops causes access excpetion

[TygerFish]

Here's what I did:
1) Made a train station on a hill
2) Decided that I wanted to flatten the hill and rebuild the station one level lower so it was even with the surrounding terrain
3) Delete tracks (ground is still there)
* At this point, convoys using the station get the expected "can't find route" message
4) Lower hill (so that there is no longer ground at the same x,y,z coordinates, just air)
* After a few seconds of simulation running, grund_t::get_halt() causes an access exception.


Also experienced this (seems to be the same issue) while altering the coastline near a ship, and can reproduce in the issue easily in the demo map,.


I broke out the complex statement in the method, and the culprit seems to be grund_t::flags




Call stack:

   Simutrans-Experimental-debug.exe!grund_t::get_halt()  Line 564 + 0x3 bytes   C++
   Simutrans-Experimental-debug.exe!convoi_t::laden()  Line 3762 + 0x43 bytes   C++
   Simutrans-Experimental-debug.exe!convoi_t::step()  Line 1419   C++
   Simutrans-Experimental-debug.exe!karte_t::step()  Line 3702   C++
   Simutrans-Experimental-debug.exe!karte_t::interactive(unsigned int quit_month)  Line 6442   C++
   Simutrans-Experimental-debug.exe!simu_main(int argc, char * * argv)  Line 1276   C++

[Dwachs]

Is this reproducable with standard's newest release? Otherwise I will move this to the simutrans-experimental board.

[prissi]

Seem to be exclusive to experimental.

[TygerFish]

Seem to be exclusive to experimental.

Yeah, my bad -- meant to post this an an -Experimental bug.

[jamespetts]

TygerFish - may I ask: which version were you using? I think that an issue like this has been resolved recently in the development version.

Edit: Can you try the latest released version, 10.12, to see whether the problem is there fixed?

[TygerFish]

I built from the latest source here: https://github.com/jamespetts/simutrans-experimental


Is that not up-to-date?

[jamespetts]

Which branch did you use? Until earlier to-day (after your post reporting the problem), the -master branch (the one viewed/downloaded by default) dated back to March of this year. Have you tried the new release version?

[TygerFish]

Confirmed that this specific bug is NOT present in the current (October 2012) version.


I did find another similar bug in a few hours of playing though... is there a more recent source repository available where I can debug it?

[jamespetts]

Thank you for confirming that. The latest source branch is currently the 10.x branch.

[TygerFish]

Forked from your 10.x branch, built and this bug isn't there either.  I'd consider this resolved.

[jamespetts]

Thank you for letting me know!