Linux: executable flags and get_pak problems

[sumpfralle]

Hi,

after downloading and extracting simulinux-112-0.zip I noticed that the two executable files ("simutrans" and "get_pak.sh") are not marked as executable. This will prevent them from being run. It can be fixed by running "chmod +x FILENAME".
Maybe the zip archive was packaged on a non-linux machine - thus there were no executable flags supported by that filesystem?

The other problem is the name of the script for downloading pak sets. The extracted filename is "get_paks.sh". But the "simutrans" executable tries to run "get_pak.sh". Either the file needs to be renamed or the binary needs to point to the real filename.

Additionally there are two problems in the "get_pak" scripts:

• a quote is missing at the start of line 43
• curl needs a parameter "-L" in case of http redirects (as it happens all download URLs)

Additionally there are some more small issues in the shell script (cosmetics & style). Please consider my changes (including the two problems above) described in this patch:
http://pastebin.com/XHmvcLXa

thanks for working on simutrans!
cheers,
Lars

[prissi]

And thank you very much, the existing script was mostly tested on windows and Haiku. You could have attached the patch also here.


Chmod is actually done for simutrans, since the zip is packed in a unix machine. I have to look up how to set get_pak.sh with exe bit. It did run on my machine without any modifications. Not sure, if this is a new ubuntu zip security feature ...

[sumpfralle]

Hi prissi,

uploading patches: thanks for the hint - I overlooked this feature ...

Simutrans executable flag: currently I see the following here:

Code Select Expand


$ unzip /home/lars/Desktop/Downloads/simulinux-112-0.zip
$ ls -l simutrans/simutrans
-rw-r--r-- 1 lars lars 3339640 Okt 22 23:37 simutrans/simutrans


Regarding the get_pak.sh executable flag: here I see the following (with the patched script but without executable flag):

Code Select Expand


$ ./simutrans
sh: 1: /home/lars/ttt/simutrans/simutrans//get_pak.sh: Permission denied


It looks like you try to execute the file directly (excuse my pseude-code):

Code Select Expand

execve(get_pak.sh", ..)
This requires the executable flag. But if you run it via

Code Select Expand

execve("/bin/bash", ["get_pak.sh", ..]..)
then you do not need the flag.
Maybe the method of calling the script changed somewhen?

And for the last detail: there is Debian here - so I don't think this is caused by weird Ubuntu madness

Have a nice day!
Lars

[prissi]

For the unix build I simply ran "./distribute.sh". This should have added the file to the zip file as is was on the disc. MAybe when looking into it on windows before upload, windows remove those (even though I did not copy anything into the zip.) I will take extra care of this next time.

And the script is run by

Code Select Expand


char command[2048];
sprintf(command, "%s/get_pak.sh %i", path_to_program, portable);
system( command );

Otherwise it will be very difficult to the the right path for the shell.

[sumpfralle]

The "system" call (at least according to its manpage) uses "sh -c COMMAND" to execute the given string. This means that COMMAND (here "/FULL/PATH/get_pak.sh") needs to be executable anyway.

Thus you probably used a non-standard environment if it allowed you to execute the script without an executable flag