Position to screen and a visual mistake

[Yona-TYT]

1. The position of the screen on the minimap is incorrect (not centered)
2. Below you can see a visual error (happens in Mountains are high)

Save...http://bit.ly/1aaovh8 
      - Pak64
      -sim-winsdl_2013-10-04_v112.4_r6781.zip

[prissi]

This will happen when the height exceeds a certain level, depending on pak set height level. I think for pak 64 this is somewhat in the mid 20ies.

[Yona-TYT]

This will happen when the height exceeds a certain level, depending on pak set height level. I think for pak 64 this is somewhat in the mid 20ies.

Which I says of alignment frame ""on the minimap??

[TurfIt]

The two issues are from the same reason - height isn't properly accounted for. The box in the minimap is technically correct - it's outlining the area being displayed, at height 0. Higher ground from outside the area is hiding the ground in the box that would be shown otherwise, and the drawing routine isn't checking for high ground far enough outside the area, so the visual error occurs. To be fixed, in the meantime, don't use heights >= 24.

[Yona-TYT]

Oh, ok!


I hope this is fixed soon

[Ters]

I wouldn't hold my breath. The code for this frightens me.

[Dwachs]

2. Below you can see a visual error (happens in Mountains are high)

This should be fixed with r 6785.

@Ters:

Code Select Expand


// better not try to twist your brain to follow the re-transformation ...

.. from simview.cc - one of my favorite comments in the code.

Edit: attached a patch for the minimap-problem. Now the tile under each corner of the screen is searched. If there are hilly regions displayed, this leads to a distorted rectangle in the minimap.

[Dwachs]

This is now incorporated in r6806.

[Yona-TYT]

Dwachs good job, works great