[r6912] Strange city road generation near water

[Spacethingy]

Hey guys, booted up r6912 on Lubuntu (latest pak64 too) for the first time and this was the first thing that grabbed my attention:






Also in other paks: (pak96)


These images show generated city roads going mad when hitting water - both sea and lake - and building a tile of bridge for no apparent reason.

[prissi]

Likely my new bridge code broke this. Thank you for reporting.

EDIT: Please try r6917 or higher.

[eipi]

Hm, just noticed this is also true for city roads near rivers:


Another issue is that bridge ramps can be built over other ways:

[prissi]

Should be also fixed in r6920

[Dwachs]

Still problems: one cannot connect bridge to elevated way. If one builds a rail bridge to a vertical cliff and there is a road on top with wrong direction a crossing is created nevertheless with wrong directions.

[prissi]

The connection to any road on a cliff is intended; especially with tunnels or when there is a station, you need the autoconnections. It must check however, if it can connect (But that is the task of the bridgebuilder, the cliff should be always a valid end tile.)

[Dwachs]

Still problems when creating bridges to cliffs with automatic generation of crossings:
(1) program crashes if required crossing type is not available
(2) crossings will be places regardless of the ribi of the existing way: crossings on curves, with two parallel ways etc
The checks in lines 172-200 in brueckenbauer.cc revision pre r6912 were there for a reason.

[prissi]

My intention was to do not automatically build the way, but only when needed. But I see the problem, when I have two bridges connecting, a player has to click on the bridge to connect, which might be not very straight forward. Ok, I will add the checks again.

Still, a bridge directly connecting to a tunnel does not work without overbuilding. This I need to fix too.

EDIT: I hope I fixed it for good in r6935, because I will not look at a computer screen (well not mine at least) until Wednesday.