The International Simutrans Forum

 

Author Topic: A few fixes for signals  (Read 2480 times)

0 Members and 1 Guest are viewing this topic.

Offline Vladki cz

  • Devotee
  • *
  • Posts: 2716
    • My addons, mostly roadsigns
  • Languages: EN, CS
A few fixes for signals
« on: December 22, 2015, 11:45:46 PM »
Hi a have noticed that some signals are in wrong place - longblock mixed with choose signals, I found that the underground longblock signal was coded as choose signal.

Colour light signals did not have retire_year (typo -/=)

Both narrowgauge semaphore choose signals had the same intro/retire dates

Added offset_left=0 for maglev signals.

More fixes to make it compilable with make on linux. (case sensitivity, backslashes, missing signals in Makefile)

Update:

added offset_left for one_way and end_of_choose, added one_way for narrow gauge, fixes in compat.tab
« Last Edit: December 23, 2015, 08:42:36 PM by Vladki »

Offline The Hood

  • Moderator
  • *
  • Posts: 2889
  • pak128.Britain developer
Re: A few fixes for signals
« Reply #1 on: December 31, 2015, 12:41:31 PM »
Thanks - now fixed in SVN.

Offline Drewthegreat87

  • *
  • Posts: 44
  • Languages: EN, DE
Re: A few fixes for signals
« Reply #2 on: December 31, 2015, 07:47:26 PM »
I don't know if this was caught or not, but the choose signal semaphores from 1860 to 1918, the Early and Intermediate versions have the same intro/retire date of 1880 to 1918. I made the corrections and make the .pak files, however, these don't include the changes that were mentioned above as I did this last night. Here's the .dat main file for what it's worth with the corrections to the intro/retire dates. I noticed in the GitHub, the same error was present in the .dat file. Essentially, you don't have choose signals for twenty years between 1860 and 1880, but as I said, that's corrected here, just not the other signal issues. I guess I'll have to repak, haha!


Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9569
  • Languages: De,EN,JP
Re: A few fixes for signals
« Reply #3 on: October 23, 2018, 11:32:58 AM »
Fixed in r1988