Started by THLeaderH, April 07, 2018, 09:23:26 AM
0 Members and 1 Guest are viewing this topic.
Quote from: Phystam on April 08, 2018, 03:13:07 PMCan I update the existing over-taking-mode status, without upgrading the existing road?
Quote from: jamespetts on April 09, 2018, 10:26:25 PMCan I check whether the bug that Phystam has reported has been fixed yet? It would seem sensible for me to begin testing this after that has been fixed.
Quote from: Phystam on April 18, 2018, 04:06:11 PMSometimes city road is downgraded with low-axle-load road, so many "no route" messages are displayed on the window.I think that the issue cannot happen at non-OTRP Extended version. Did you change the code about road renovation?
Quote from: Phystam on April 22, 2018, 06:11:30 PMI found another bug about building roads.When I selected the road builder tool using "s" shortcut key, the "oneway" mode was ignored and the road was built with "twoway" mode.(This issue cannot be seen when I clicked the road icons.)
FATAL ERROR: successfully_loaded() - class skin_desc_t-object RibiArrow not found.*** PLEASE INSTALL PROPER BASE FILE AND CHECK PATH ***Aborting program execution...
QuoteIf so, it would seem to make more sense to allow it to work, albeit without this feature enabled, with a non-modified version of the pakset, as Simutrans has traditionally always been strongly backwards compatible with older pakset versions, and it would be a great shame to break this now.
Quote from: Matthew on June 01, 2018, 10:49:40 PMThank you to @THLeaderH and @jamespetts for working together to bring a new feature to Simutrans-Extended.I have downloaded the latest nightly .exe and pakset, but so far I cannot see any new icons or other changes in the Roads menu. Is this new feature still 'under construction'? I realize this might just be the first of several changes. Or do I need to wait until motorways become available? Or am I simply missing something obvious (either in the GUI or in the file structure)?
Quote from: jamespetts on June 01, 2018, 11:23:15 PMThe user interface may need a little polishing perhaps as it is slightly non-obvious - but the way to use this feature is to CTRL+click when selecting a road to build. You are then given a menu of the different modes available. Building a road over another road of the same type but with a different mode selected will alter the overtaking mode of the underlying road without upgrading it or costing anything.
Quote from: ACarlotti on June 02, 2018, 02:07:40 PMNote: This ended up being quite a long post, in which I express quite a bit of frustration. The first half of the post is about specific issues in THLeaderH's changes, many of which had been raised before. The second half is a more general discourse on code quality, both in the context of these changes and the codebase more generally, and about my opinions and aims regarding quality and how they compare with those of THLeaderH, James and the main developers of Standard.I was looking through these changes last night, and I noticed that many of the issues mentioned in the Standard thread for this patch are still present in this thread. I've made some changes to your code, which James has now incorporated into master, so you should be able to look at them fairly easily. In no particular order.