Memory leak of the depot dialog

[RESTRICTED ACCOUNT]

That duplicate drawing code may actually have been more deeply rooted. I wondered why clicking on a gray or red bar panel would affect the transparency.
Because they are vehicles that can not be selected, no action should be taken when clicking it.
Despite that, each click on it will increase memory usage. In addition, closing the depot dialog does not reduce the increased memory usage.
For example, the memory usage, which was originally 1131 KB, became 1149 KB when the game paused and just clicked on the red bar vehicle panel continuously in the depot dialog.
In-game time is not moving and I have not bought any vehicles but just clicking, so there should be no change in the game world.
This memory consumption could not be corrected by fixing the duplicate vehicle panel drawing.
If you want to check this symptom, set allow_buying_obsolete_vehicles = 1 or use timeline off, and it will be clearer if you show all vehicles and show many vehicles in the depot. I recommend the electrified railway depot with timeline off for checking this.
The memory usage will increase even if you repeat the show all on and off in the same way as the duplicate image display testing.
This memory leak can not be confirmed in standard.

[jamespetts]

Thank you for your report; I believe that I have managed to fix this. I should be grateful if you could re-test with the next nightly build.

[jamespetts]

Can anyone confirm whether this can still be reproduced after the fix that I applied in December?

[Mariculous]

At least I could not reproduce it anymore