[BUG] Bridgewater-Brunel down possibly due to build issue

[Matthew]

Bridgewater-Brunel has been down since this morning's nightly reset.

Symptoms

B-B built neither the client nor the server builds this morning (though it did built nettool).

Running yesterday's client produces the following:

Code Select Expand

FATAL ERROR: vehicle_reader_t::read_node() - Incompatible pak file version for Simutrans-Ex, number 7
Aborting program execution ...

For help with this error or to file a bug report please see the Simutrans forum at
https://forum.simutrans.com
The Updater updated all the vehicle .paks in both pak128.Britain-Ex and pak128.Sweden-Ex. But this should not have been necessary. E.g. pak128.Britain-Ex trams have not been changed for a year. So I wonder if there was a build error on B-B. Perhaps the Nightly was built from a development branch rather than the Main branch ('master')

I will try to compile from the Main branch later today, but I need to do some work right now.

[Matthew]

Reported on Discord by TransshipmentEnvoy - executable build fails as follows:

Code Select Expand

simhalt.cc: In member function 'void haltestelle_t::rotate90(sint16)':
simhalt.cc:712:30: warning: comparison of integer expressions of different signedness: 'uint32' {aka 'unsigned int'} and 'const sint32' {aka 'const int'} [-Wsign-compare]
  712 |         for (uint32 i = 0; i < po; i++)
      |                            ~~^~~~
simhalt.cc: In member function 'void haltestelle_t::liefere_an(ware_t, uint8)':
simhalt.cc:3393:17: error: jump to label 'walking'
 3393 |                 walking:
      |                 ^~~~~~~
simhalt.cc:3328:30: note:   from here
 3328 |                         goto walking;
      |                              ^~~~~~~
simhalt.cc:3353:30: note:   crosses initialization of 'const uint16 straight_line_distance_to_next_transfer'
 3353 |                 const uint16 straight_line_distance_to_next_transfer = shortest_distance(get_init_pos(), ware.get_zwischenziel()->get_next_pos(get_next_pos(ware.get_zwischenziel()->get_basis_pos())));
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
simhalt.cc: In member function 'void haltestelle_t::display_status(sint16, sint16)':
simhalt.cc:5167:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
 5167 |                 if (i==goods_manager_t::INDEX_PAS && !get_pax_enabled() || i==goods_manager_t::INDEX_MAIL && !get_mail_enabled() || i>goods_manager_t::INDEX_NONE && !get_ware_enabled()) {
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
simhalt.cc:5167:163: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
 5167 |                 if (i==goods_manager_t::INDEX_PAS && !get_pax_enabled() || i==goods_manager_t::INDEX_MAIL && !get_mail_enabled() || i>goods_manager_t::INDEX_NONE && !get_ware_enabled()) {
      |                                                                                                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~

[jamespetts]

Thank you for the report. I have now fixed this and rebuilt the server, which is now running again.