Is this intended (simconvoi.cc)?

[jamespetts]

Working to merge the latest Standard release into Experimental, I came accross the following in simconvoi.cc, which looks on the face of it as if it might be a mistake:

Code Select Expand


if(file->get_version()>=111001) {
         file->rdwr_long( distance_since_last_stop );
         file->rdwr_long( sum_speed_limit );
     }

    if(  file->get_version()>=111002  ) {
        file->rdwr_long( sum_speed_limit );
    }
    else if(  file->is_loading()  ) {
        // default when not saved
        maxspeed_average_count = 0;


The file->rdwr_long( sum_speed_limit ); seems to be called twice if the file version is > 111002. Is this a mistake or is this on purpose?

[VS]

Intended or not, I assume this has to stay now, since it would break existing saves...

Oh wait, these are for nightlies... then it's probably fixable.

[TurfIt]

That would be a classic cut'n'paste error. 

[prissi]

It is
maxspeed_average_count (or will be after the mac OS is built an uploaded)