The International Simutrans Forum

 

Author Topic: Suspended monorail (Schwebebahn) needs correction of Images  (Read 6084 times)

0 Members and 1 Guest are viewing this topic.

Offline Václav

  • Devotee
  • *
  • Posts: 3230
  • formerly VaclavMacurek
  • Languages: CZ, EN
I have found that suspended monorail (Schwebebahn) got FrontImages - but this change was not perfect.

1. Diagonal tiles disappeared - and so, where they were, there is row of curves and building is not looking good
2. FrontImages and BackImages were prepared wrong. May it be that pictures were prepared well and dat files not - but it seems like dat file is OK and pictures were not changed in right way - because originally vehicles were in the front of track, and now is behind track

Mostly for point 2 I created screenshot I attached to this post. Screenshot shows vehicles in diagonal tile - but situation on basic tiles is the same. I am worried about that only one way is preparing of new track.

Offline VS

  • Senior Plumber (Devotee)
  • Devotee
  • *
  • Posts: 4855
  • Vladimír Slávik
    • VS's Simutrans site
  • Languages: CS,EN
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #1 on: May 12, 2012, 09:43:50 AM »
Can you please make a screenshot showing #1 ? I'm not sure if I understand that...

#2 - Oops, some pillars should be in backimage.

Offline Václav

  • Devotee
  • *
  • Posts: 3230
  • formerly VaclavMacurek
  • Languages: CZ, EN
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #2 on: May 12, 2012, 10:14:43 AM »
VS, you can see point #1 at that screenshot too - look to the right of monorail station - where train goes.

Originally there were diagonal tiles - because track is laid in diagonal direction for too long distance (5 tiles).

And by the right side of picture, there is another place where track is laid in diagonal direction - 3 tiles from train station to crossing - and more than 3 tiles from crossing up.

Offline DirrrtyDirk

  • Devotees (Inactive)
  • *
  • Posts: 1253
  • JR 700 Series Shinkansen
  • Languages: EN,DE
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #3 on: May 12, 2012, 01:18:46 PM »
Ok, my guess is that this is actually a program bug... Looking at the dat and the png, it seems to me that the only change was to reassign almost all images to frontimages, but nothing more. And that should not affect diagonals.

Offline Fabio

  • Devotee
  • Administrator
  • *
  • Posts: 2898
  • The Pak128 Guy
    • Visit me on Facebook
  • Languages: EN, IT, RO, FR
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #4 on: May 12, 2012, 01:21:31 PM »
I might take a shot at overhauling the schwebebahn in the near future, I have a couple of ideas I would like to try...

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4555
  • Languages: EN, DE, AT
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #5 on: May 12, 2012, 01:34:52 PM »
Ok, my guess is that this is actually a program bug... Looking at the dat and the png, it seems to me that the only change was to reassign almost all images to frontimages, but nothing more. And that should not affect diagonals.
I can confirm that there is a program bug. The program checks only background images to decide whether the way has diagonal images. (same for switches)

Offline VS

  • Senior Plumber (Devotee)
  • Devotee
  • *
  • Posts: 4855
  • Vladimír Slávik
    • VS's Simutrans site
  • Languages: CS,EN
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #6 on: May 12, 2012, 01:59:18 PM »
WRT the original report, I'm working on splitting the graphic into front and back...

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4555
  • Languages: EN, DE, AT
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #7 on: May 12, 2012, 02:08:04 PM »
The bug that no diagonal images are shown is fixed in r5708.

Offline VS

  • Senior Plumber (Devotee)
  • Devotee
  • *
  • Posts: 4855
  • Vladimír Slávik
    • VS's Simutrans site
  • Languages: CS,EN
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #8 on: May 12, 2012, 04:10:26 PM »
Both schwebebahn ways should be fixed with r863.

(edit: The bridge hasn't been touched yet, maybe it does not need?)



But there is now another ugly bug... the way is drawn on top of depot. Not sure how to bypass this...?
« Last Edit: May 12, 2012, 04:31:10 PM by VS »

Offline DirrrtyDirk

  • Devotees (Inactive)
  • *
  • Posts: 1253
  • JR 700 Series Shinkansen
  • Languages: EN,DE
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #9 on: May 12, 2012, 04:20:09 PM »
Probably another program bug. ;)

Offline VS

  • Senior Plumber (Devotee)
  • Devotee
  • *
  • Posts: 4855
  • Vladimír Slávik
    • VS's Simutrans site
  • Languages: CS,EN
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #10 on: May 12, 2012, 04:30:19 PM »
Well, yeah... This sounds like revisiting the drawing order hell, though, so I'm sympathetic to the programmer(s) :) I hope this doesn't lead to stuff like SuperFrontImage :P

Offline Fabio

  • Devotee
  • Administrator
  • *
  • Posts: 2898
  • The Pak128 Guy
    • Visit me on Facebook
  • Languages: EN, IT, RO, FR
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #11 on: May 12, 2012, 10:48:06 PM »
VS, try this workaround:
- depots are built on terminal tiles, hence terminal tiles might have only back and no front image.

Just try it and let me know, please ;)

Offline Václav

  • Devotee
  • *
  • Posts: 3230
  • formerly VaclavMacurek
  • Languages: CZ, EN
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #12 on: May 13, 2012, 06:06:36 AM »
Diagonal tiles corrected, I confirm. One bug eliminated.

VS, try this workaround:
- depots are built on terminal tiles, hence terminal tiles might have only back and no front image.
Depots need both images - for coverage of tracks. But you may think that there front image is missing, or not?

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4555
  • Languages: EN, DE, AT
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #13 on: May 13, 2012, 07:28:24 AM »
Fabio suggested to remove the front image of the way. This front image will be always drawn on top of front image of depot.

Offline Fabio

  • Devotee
  • Administrator
  • *
  • Posts: 2898
  • The Pak128 Guy
    • Visit me on Facebook
  • Languages: EN, IT, RO, FR
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #14 on: May 13, 2012, 08:17:34 AM »
Exactly-- as Dwachs explained ;)

Offline Sybill

  • *
  • Posts: 74
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #15 on: May 13, 2012, 05:44:50 PM »
I have the same problem with my tube rail depots. The front image of the depot should be drawn on top of the  front image of the way, otherwise it's impossible to use front images for ways at all. Or it must be possible to make special end tiles for ways (without front images) only for the use with depots and maybe stations.
Maybe I miss something, but I can't see a solution here - other than make the depot looking like the front image of the way.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4555
  • Languages: EN, DE, AT
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #16 on: May 13, 2012, 06:10:37 PM »
An option would be to not show the front image if there is a depot on the tile. This could lead to other sort of errors as well.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4555
  • Languages: EN, DE, AT
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #17 on: May 18, 2012, 11:56:44 AM »
There is a related report at the German forum:

http://simutrans-forum.de/forum/thread.php?postid=83000#post83000

Images are wrong on sloped tiles. I did not check whether it is already fixed.

Offline VS

  • Senior Plumber (Devotee)
  • Devotee
  • *
  • Posts: 4855
  • Vladimír Slávik
    • VS's Simutrans site
  • Languages: CS,EN
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #18 on: May 18, 2012, 06:26:10 PM »
Re bug linked by Dwachs: I think it's a bug of the program, too. Maybe. There are two components to the problem:

1) The images shown there are the "down" slopes of way, which are for some reason... raised above the bridge? Try building the normal "low" schwebebahn on sides of a ditch and bridging these, it shows well.

2) It may be connected to the fact that these are front images. Ideally, they should be hidden by the bridge... I think. Dunno why it works for other ways. Will investigate more once I have time.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4555
  • Languages: EN, DE, AT
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #19 on: May 18, 2012, 07:17:24 PM »
Bug fixed in r 5724.

Offline VS

  • Senior Plumber (Devotee)
  • Devotee
  • *
  • Posts: 4855
  • Vladimír Slávik
    • VS's Simutrans site
  • Languages: CS,EN
Re: Suspended monorail (Schwebebahn) needs correction of Images
« Reply #20 on: May 19, 2012, 10:53:29 AM »
Confirmed! Many thanks :)