Max zoom tile edge bug

[Spacethingy]

Evenin' all, here's a little annoyance that only occurs on max zoom (in all paks it seems):



As you can see, when the brightness is changed, an outline is left around the edge of all the tiles. As soon as I move the view point, the lines disappear.


Also, the outlines are left behind when a vehicle moves over the tile. Look closely at the edges of the tiles on the corner and you can see blue and red pixels left behind by the bus. Again, the rogue pixels disappear when I move the viewpoint or change the zoom.




I'm on 111.3.1 r5843, with a Mobile Intel(R) 945GM "card" if that helps. I don't know if this counts as a bug, it's such a small thing, but thanks for your help anyways!

[prissi]

It dependes on pak set size too. One would need to change the zooming out routine to add a extra pixel every second row for maximum level. Nobody bothered yet, but I think almost everybody saw this.

[Dwachs]

Here is a patch. The bug appears in all paksets in full zoom in, ie 2:1 zoom. This is due to the applied diagonal filtering: some pixels are made transparent, but no pixels are made opaque. Hence some transparent pixels appear between ground tiles.

Please test

[kierongreen]

Patch seems to work fine here

[TurfIt]

The grid is unfortunately affected by the patch. North/South lines disappear in pak128. All lines gone in pak96.comic. Just blobs in the tile corners left.
But the original problem is fixed. 

[Ters]

I've wondered, why do people zoom in? Retro look with big pixels? Touch screen users with big fingers?

[Spacethingy]

Thanks! Re. zooming in, I do it in 64-sized paks with slow vehicles, as it makes their motion look smoother. Also, I like just sitting watching things happen in a small area, like I'm waiting at a station... (does that sound weird? )

[Dwachs]

Here is an updated patch, the grid is preserved to some extent.

[IgorEliezer]

Also, I like just sitting watching things happen in a small area, like I'm waiting at a station... (does that sound weird? )

So, wait when Simutrans goes isometric 3D.

[prissi]

Look fine to me. It just make the fact more visible that pak32 and pak192 has cursor outlines, that are shifted 1-2 pixel versus their intended position. But that is a pak error. Please commit.

[Dwachs]

This is now incorporated, r5998.