News:

Simutrans Chat Room
Where cool people of Simutrans can meet up.

Ship changes line on its own

Started by zook2, August 30, 2021, 08:55:38 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

zook2

A weird one (and reproducible):
on the BB server, go to the dock at 217,600 (password: pw). Buy a boat, set the line to "#- Welsh Potatoes". It shows up in the line list in the white font. Launch it. A second later it disappears from the potato line and is now in "#- Welsh Bulk & Goods".

zook2

Confirmed now. If I have two lines with identical stops (e.g. one freight line and one cargo), the game often auto-assigns a new convoy to the other line (perhaps based on some kind of internal line ID?) and not the one I selected in the depot. A second after leaving the depot my "Foo - Bar Express" passenger train slips into "Foo - Bar Cargo Express". After manually reassigning it, everything's OK.

Mariculous

#2
I'm not sure if this is a bug or a feature...
What's going on is that that the line comparator method used to compare schedules is used to select a line with the same schedule.
If they match, the first matching line will be assigned.

Matthew

It seems that this can be worked around relatively easily using waypoints. But it's undocumented and confusing, especially for new players.
(Signature being tested) If you enjoy playing Simutrans, then you might also enjoy watching Japan Railway Journal
Available in English and simplified Chinese
如果您喜欢玩Simutrans的话,那么说不定就想看《日本铁路之旅》(英语也有简体中文字幕)。

Mariculous

#4
Definitely. This is confusing and should be fixed.

I am not exactly sure about the intention of this code.
This behavior seems to be meant to re-assign the original line of a convoy when it's leaving the depot as the line is unassigned when a convoy enters the depot.
This method (schedule_t::matches) is based on more than just the waypoints. It does also account for the schedule options.

I am wondering if instead of this admittedly confusing re-assignment mechanism, convoys should instead "simply"* not un-assign their line when entering a depot.
The same can be observed in further cases, e.g. when changing the schedule of a convoy outside of the depot.

*I did not yet check how simple this actually is.

Ranran(retired)

#5
I am trawling through past bug reports. Because we may find something new or have a chance to solve the bug. (´・ω・`)
I recently noticed that there is such a specification in the standard. It seems that it is not possible to make each convoy belong to multiple lines with duplicate schedules. It is aggregated on one side.
I don't know if it was brought to extended by the merge, or if it is an original specification.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

I believe that this is a long established original feature dating from before Extended was forked from Standard.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.