News:

Use the "Forum Search"
It may help you to find anything in the forum ;).

Wrong variable setting in citylures.tab

Started by Ranran(retired), October 23, 2022, 08:52:49 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Ranran(retired)

renovation_range_proportions_res = 160
renovation_range_proportions_com = 100
renovation_range_proportions_ind = 200
I'm pretty sure this patch (thread) is relevant, but I found there is no such parameter in the code. maybe renovation_range_com is the correct parameter.
I think we have done very little testing on this feature.
I'm currently working on extended paksets, but setting up citybuilding balance is very fragile and difficult.

https://github.com/Ranran-the-JuicyPork/simutrans-exp/tree/2210-debug-city
This test branch displays the number of ind/com/res in the city info window. You guys can confirm that com is very few as I have reported many times. (Try setting all parameters to 0.) Adjusting this balance seems to be less straightforward and fragile than standard.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

These parameters do exist, albeit their names are not very clear: see the following lines in simcity.cc:

renovation_ranges_by_type
[0][o]= (uint16)contents.get_int("renovation_range_res", renovation_ranges_by_type
[0][o]);
 renovation_ranges_by_type[1] = (uint16)contents.get_int("renovation_range_com", renovation_ranges_by_type[1]);
 renovation_ranges_by_type[2] = (uint16)contents.get_int("renovation_range_ind", renovation_ranges_by_type[2]);
[0][o]
  • As to city building generally, I think that it is sensible not to do too much on this before the planned fundamental overhaul of the city growth code.

Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Ranran(retired)

Quote from: jamespetts on October 23, 2022, 10:19:26 AMThese parameters do exist, albeit their names are not very clear: see the following lines in simcity.cc:
What I mean is that the correct variable name is strictly without "_proportions".

renovation_range_proportions_res  :redx:
renovation_range_res  :thumbsup:
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

Quote from: Ranran on October 23, 2022, 10:43:19 AMWhat I mean is that the correct variable name is strictly without "_proportions".

renovation_range_proportions_res  :redx:
renovation_range_res  :thumbsup:
Ahh - I had not spotted that. Thank you; now fixed in the pakset.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.