since 124.0: trains not loading passengers

[ALFA-X]

Hi Simutrans community

I noticed that since version 124 some of my trains going around with no passengers aboard.
But stations had plenty of passengers waiting (and destination not overcrowded).

(it would ruin me, but luckily i play without bankruptcy^^")

Today I came across the possible reason:

Two trains on same line/schedule.
Train A already arrived and is un-/loading passengers.
Train B arrives in that very same station
Train B unloads but won't pick up any passengers and just leaves the station, if train A is still loading.

And I wondered, why more trains didn't help to reduce the number of waiting passengers (40.000+)

Is that report enough to fix that bug or do you need more info or my savegame?

I'm on r11377 and pak192.Comic V0.71

[prissi]

This has been fixed recently in the nightly. Using the nightly will give your normal passenger numbers again. Please try the nightly and report back should the error still persists.

[ALFA-X]

Bug still present in r11372 (not r11377! sry, my bad)
r11372 is most recent built on https://nightly.simutrans.com/en/

As you can see in these screenshots, there are plenty of passengers waiting, but the train arriving second just did not pick up any of those.
(and it's not in "unload only" mode)

First vehicle (1252) unloads/loads as intended
Second vehicle (1253) arrives, stops and just leaves
Station has more than enough pax for destination Hofheim

[makie]

May be "avoid_overcrowding" is the reason.
https://forum.simutrans.com/index.php/topic,22826.msg206538.html#msg206538
Is there all destinations are not overcrowded?
May be you think persons to stop A should enter the train, but the program select persons to stop B for entering and stop B is overcrowded.

OK i understand

In Version 124 only one train load at a time.
But the second did not wait until the first one is finished loading.
This can only happened with the chose signal otherwise the second train wait before the stop.

[ALFA-X]

Stop status in network all green, no overcrowded stations.

And yes: I'm using choose signals almost everywhere.

[prissi]

Please provide a savegame for debugging then.

[ALFA-X]

Sure. PMed you the link to my savegame.
(Should be faster, as my messages still need approval first before they're published)

[prissi]

The problem went away when avoid_overcrowding was turned off. Maybe the satus flag is not calculated correctly with pak192 insane high station capacities. Investigationg.

[prissi]

Ok, r11373 fixes this bug. When there were more than one convoi to a destination without loading limit, the second convoi did not load if the first convoi was served. This requires unfortunately some additional logic, making large games probably a little slower. Please check.

[ALFA-X]

Thx prissi

Observed that convoys are served one after another, not in parallel though, like it used to be when I played without avoid_overcrowding and no_routing_over_overcrowded. Guess that would add even more logic?

Fast forwarding my game, I found a new bug (most likely related to the fix):
Vehicle won't pick up anything and stays forever in loading mode never leaving the station, if destination is overcrowded. (See vehicle 890 in uploaded game.)

I'm using most recent build r11378

https://simutrans-germany.com/files/upload/game.sve

[prissi]

With overcrowding there are passengers but they do not load. This is somewhat the intended behaviour.

However, the overcrowding built up because the departure never occurred as the next stop in the schedule was the same as the current and thus never a halt to serve.

r11379 should fix this.
.

[makie]

Observed that convoys are served one after another, not in parallel though, like it used to be when I played without ....

This a is new and intended behavior in 124.
Because if 10 ships waiting for 100% loading at the pier. Sometimes happened that all ships has 10% loading and none of them continue to move.

The same can happened if you use choose signal and more the one train waits at the platform.

Maybe we could restrict this behavior to if a loadinglimit is present.

[ALFA-X]

I see. Thx for explanation, makie.

Maybe that 's indeed the key difference:

if loadinglimit present
-> serial loading (of 10 tankers serving an oil rig)

if no loadinglimit present
-> parallel loading (like people in real life would board next best train/bus)
-> leaves station when either vehicle full or no more people/items left for vehicle's (not-crowded) destination(s)

[ALFA-X]

However, the overcrowding built up because the departure never occurred as the next stop in the schedule was the same as the current and thus never a halt to serve.

r11379 should fix this.
.

Still got vehicles on halt forever in r11380 :(

Updated savegame. See tram (2647).

(Maybe another case of a station served twice in the schedule causing trouble?)

https://simutrans-germany.com/files/upload/game.sve

[prissi]

On could argue that this is intended since all the destinations after the current one are overflown. But r11381 should fix this.

PS: I am not sure why your posting are stuck in moderation. This should not happen. I am investigating this as well.

[ALFA-X]

On could argue that this is intended since all the destinations after the current one are overflown. But r11381 should fix this.

Not if destination is the final one and station is not used for transfer (which indeed would add to waiting pax/goods)

Vehicles now keep going

But routing seems broken now. :( Every station claims "no route" for passengers. Number of trips crashed.

Same savegame, r11381.

PS: I am not sure why your posting are stuck in moderation. This should not happen. I am investigating this as well.

Thanks!

[prissi]

It looks normal in my game. No route pax is also back to normal number, since these are mail and passengers.

[ALFA-X]

With r11382 everything seems fine now

Thank you very much.

[ALFA-X]

Seems I rejoiced too early.

Ok, r11373 fixes this bug. When there were more than one convoi to a destination without loading limit, the second convoi did not load if the first convoi was served. This requires unfortunately some additional logic, making large games probably a little slower. Please check.

With r11382 second convoi is not served anymore again.

Screenshots and demo savegame attached.

[prissi]

Try r11383

[ALFA-X]

This time I did some more testing: Not only fast forwarding, but also provoking overcrowded stations, turning overcrowding switches on and off to see how the system reacts now...

Seemed fine at first, but eventually ran into a "no route everywhere" situation again.

Though I noticed this time, it wasn't "no route everywhere" as direct connections without transfer still seemed to work. Some station showing something like: "Passengers 2 +, 0 -, 1542 no route"

However, after saving and reloading the problem automagically disappeared.

Unfortunately I was unable to reproduce that bug.

[prissi]

Saving reloading, changing schedules or lines, all triggers a rerouting.

That no transfers work but only direct routes is plausible for no routing over overcrowded.

[Flemmbrav]

Thank you for fixing this! We just ran into the same issues on our network game.
In case you need a reference map to test this out, I can provide that one as well.

r11387 seems to fix this. But I'll also keep my eyes out in case something similiar shows up again.