no_routing_over_overcrowded causes unhappiness in separate network

[ceeac]

In the attached save, there are two separate passenger networks: a northern one and a southern one.
If a stop in the southern network is overcrowded, this will cause unhappy passengers to be logged in the southern network (this is expected).
However, unhappy passengers will also be logged in the northern network even though it has no overcrowded stops. This is counter-intuitive, and misleading in multi-player games because an overcrowded network of another player can cause orange halt statuses in your own network even though your own network works fine.

[ceeac]

Should hopefully be fixed in r11902.

[prissi]

Thank you. What is the logic of adding the no route passengers only to one stop and not all stops in the catchment point (line 1959)? They could potentially travel from any of them.

It will certainly change the number of no_route passengers in normal games.

[ceeac]

What is the logic of adding the no route passengers only to one stop and not all stops in the catchment point (line 1959)?

The logic has not changed; GCC just did complain about the loop being run at most once, and judging by the comment on the line directly above, this was probably intentional (?)