r11731 - AI built

[Andarix]

In the course of time, this station was built by the AI.

I can't make any further statements about it because I've only just discovered it.



[edit]

The road was there first.

[ceeac]

Was the station built by the script AI or the C++ AI?

[Andarix]

script AI

[victor_18993]

Fixed in r12242.

The issue was in the station-building core: when a script supplied an explicit layout/rotation, the normal way-direction validation was skipped, allowing a station to be built on an invalid track layout.

The explicit-layout path now uses the same validation as the normal building path. Valid cases such as end-of-line stations and tram tracks embedded in roads are preserved.

I also added a regression test for this case.
Thanks for reporting it — the Script AI made the problem much easier to expose and reproduce.