[crash dev] probably related to circular route patch

[sdog]

http://forum.simutrans.com/index.php?topic=5262.0

crash happened this way:

created line,
set mirror route flag,
applied route,
copied convoys,
opened schedule for a convoy,
remembered 'circular route flag,
set it for the line,
deleted convoy, immediate crash

Code Select Expand


FATAL ERROR: unknown
pure virtual function call


Program received signal SIGABRT, Aborted.
0x00007ffff6c1fa75 in raise () from /lib/libc.so.6
(gdb) bt
#0  0x00007ffff6c1fa75 in raise () from /lib/libc.so.6
#1  0x00007ffff6c235c0 in abort () from /lib/libc.so.6
#2  0x000000000063afc8 in log_t::fatal (this=0xa7c3c0, who=0x69605b "unknown",
   format=0x696040 "pure virtual function call") at utils/log.cc:242
#3  0x00000000005b79c4 in __cxa_pure_virtual () at simdebug.cc:36
#4  0x000000000045528d in dingliste_t::get_convoi_vehicle (this=0x5490510)
   at dataobj/dingliste.cc:724
#5  0x000000000051334e in grund_t::get_convoi_vehicle (this=0x5490508)
   at gui/../boden/grund.h:637
#6  0x000000000050f691 in reliefkarte_t::calc_map_pixel (this=0x205b200, k=...)
   at gui/karte.cc:294
#7  0x0000000000648a6f in ~vehikel_t (this=0x466af60,
   __in_chrg=<value optimized out>) at vehicle/simvehikel.cc:2187
#8  0x000000000065448f in ~automobil_t (this=0x466af60,
   __in_chrg=<value optimized out>) at vehicle/simvehikel.h:565
#9  0x00000000005b2f96 in convoi_t::destroy (this=0x6865c50)
   at simconvoi.cc:3831
#10 0x00000000005b2b6b in convoi_t::self_destruct (this=0x6865c50)
   at simconvoi.cc:3773
#11 0x00000000005b9c70 in depot_t::disassemble_convoi (this=0x7a8f880,
   cnv=..., sell=true) at simdepot.cc:411
#12 0x000000000060ddd2 in wkz_change_depot_t::init (this=0x6a21ef0,
   welt=0x15a8f80, sp=0x78ae7f0) at simwerkz.cc:5477
---Type <return> to continue, or q <return> to quit---
#13 0x0000000000620af1 in karte_t::local_set_werkzeug (this=0x15a8f80,
   w=0x6a21ef0, sp=0x78ae7f0) at simworld.cc:2340
#14 0x00000000006209e1 in karte_t::set_werkzeug (this=0x15a8f80, w=0x6a21ef0,
   sp=0x78ae7f0) at simworld.cc:2326
#15 0x00000000005b865a in depot_t::call_depot_tool (this=0x7a8f880,
   tool=118 'v', cnv=..., extra=0x0) at simdepot.cc:138
#16 0x00000000004e31d6 in depot_frame_t::action_triggered (this=0x6c677c0,
   komp=0x6c67af0, p=...) at gui/depot_frame.cc:452
#17 0x00000000004ab757 in gui_action_creator_t::call_listeners (
   this=0x6c67af0, v=...) at gui/components/../../ifc/gui_action_creator.h:36
#18 0x00000000004aad27 in button_t::infowin_event (this=0x6c67ad8,
   ev=0x7fffffffb860) at gui/components/gui_button.cc:337
#19 0x00000000004fd056 in gui_container_t::infowin_event (this=0x6c677c8,
   ev=0x7fffffffb8e0) at gui/gui_container.cc:93
#20 0x00000000004fe933 in gui_frame_t::infowin_event (this=0x6c677c0,
   ev=0x7fffffffba00) at gui/gui_frame.cc:89
#21 0x00000000004e380b in depot_frame_t::infowin_event (this=0x6c677c0,
   ev=0x7fffffffba00) at gui/depot_frame.cc:518
#22 0x0000000000613973 in check_pos_win (ev=0x7fffffffbb30) at simwin.cc:938
#23 0x000000000062e691 in karte_t::interactive (this=0x15a8f80,
   quit_month=2147483647) at simworld.cc:5617
#24 0x00000000005e4535 in simu_main (argc=1, argv=0x7fffffffe2d8)
   at simmain.cc:1075
#25 0x0000000000669725 in main (argc=1, argv=0x7fffffffe2d8) at simsys_s.cc:748


if it's not obviously wrong, don't look too much. i merged 8.x and yobbobandana circular route patch myself. This could also be the source of the crash.

[jamespetts]

SDog,

I'd probably better leave this to yobbobandana to debug, but I should note that this is merged on -devel already. However, -devel also contains merges of the latest GUI changes in Simutrans-Standard, which are currently not working (I suspect a merge problem: I have not had time to investigate), meaning that the "chart" and "details" buttons in stations and convoys do not work.

[yobbobandana]

I'm having a little trouble reproducing this.

There seems to be a similar bug in simutrans SVN where deleting the convoy while leaving the schedule window open causes a crash... but I can't get this to happen with experimental.

Were you leaving the schedule window open to cause the crash?

[sdog]

i merged it into 8.x, to avoid the instability due to the incompletely implemented gui overhaul.

individual vehicles schedule windows were not open. i don't know if vehicle 'details' windows were open however. i'm not so sure about the actual procedure to get to this bug either. the one detailed above wasn't it, i realized when i repeated it, and it wasn't the same. (sorry for not being able to really remember for =< 10 minutes.)

perhaps we should leave this just here for the moment, unless further similar crashes occur.