[Bug] Travelling times wrong on circular lines with alternate directions

[HeinBloed]

I've noticed that the displayed travelling times on circular lines which have alternate directions turned on seem to be an average of the convoys travelling into the two different directions. To illustrate that, here's a screenshot:



That it's an average between the times of the two directions is only a guess, not having checked the code yet, but it's striking that the time for all the destinations is virtually the same. Needless to say that the adjacant stations are only like 5-10 minutes away if the pax choose the convoys travelling in the right direction.

I guess the time displayed here and the time used internally for routing is the same, which would mean that lots of pax decide not to travel due to the line being "too slow".

Playing with latest Windows Complete Package.

[jamespetts]

Thank you for the report- are you able to upload a saved game?

[HeinBloed]

Saved game is here: http://simutrans-germany.com/files/upload/long_travelling_times.sve

It happens for every circular line with alternate directions turned on, for example next to Berlin you can also check Hamburg on that map (the other cities with an inner city line are much smaller so the effect doesn't stand out as clearly, e.g. in Stuttgart). Mail is equally affected, too.

[HeinBloed]

As requested, here's a simple game which displays the bug: http://simutrans-germany.com/files/upload/circular_travelling_times_wrong.sve

I took a screenshot of a random station before the first convoy in the line arrived (where the travelling time is estimated based on some average speed I guess):


And another screenshot of two stations at opposite ends of the circular line two months later:



(this time with modern buses so the absolute time is much shorter, but the problem of virtually identical travelling times to all the stops remains)

[jamespetts]

I have just finished fixing this on the -devel branch: I couldn't fix this on the 10.x branch, as an update to the save game format was necessary. In essence, what was happening was that the point to point routing system was not distinguishing between convoys going in opposite directions and was averaging times between going the short way and the long way around the circle for each stop. I have now added a mechanism to determine whether a route is a bidirectional circular route, and have a separate set of point to point average times for each direction where it is. This is why the save game version needs to change, as these additional data need to be saved.

Than you very much for the report!

[inkelyad]

What about passengers? Will they use right direction?

[jamespetts]

I think that they already do.

[HeinBloed]

Thanks for all the fixes James, hope I can give them a try tomorrow!

[jamespetts]

Excellent - shall look forward to test results.

[HeinBloed]

This seems to be fixed now, thank you! But see for new bugs I've encountered in the devel thread.

[asaphxiix]

It seems to happen still, you can see it in Dorley Brownfriars Underground Railway Station on the server game, seems to be the same behavior described above, only no alternate destinations turned on. (but it is a two-way circular route, so they're should be able to take the short path)

[jamespetts]

What do you mean by "no alternate destinations turned on"?

[asaphxiix]

sorry, should be "alternate directions".