Location of addons

[MCollett]

Recent -devel builds seem to be in two minds about where addons live.  If user addons are selected at startup, files are loaded from whereever/simutrans/addons/paksetname.  But the option to select addons for a pakset isn't even offered unless there (also) exists a folder at whereever/simutrans/paksetname (i.e. not inside the addons folder).  The contents of that folder are ignored, whether or not there is another one inside the addons folder.

Best wishes,
Matthew

[jamespetts]

Hmm, I haven't looked at addons in detail. What is the behaviour of the Standard version on which the current -devel branch is built (i.e., 111.2.1)?

[Dwachs]

This change broke it:

https://github.com/jamespetts/simutrans-experimental/commit/404c86f12781dd6da3c9a92841ab3c08f49189c6#diff-60

the 'addons' string was lost in this merge (line 124).

[MCollett]

What is the behaviour of the Standard version on which the current -devel branch is built (i.e., 111.2.1)?

In 111.2.1, addons are recognised and loaded if they are in the addons folder (as announced in this thread), and ignored otherwise. 

Best wishes,
Matthew

[jamespetts]

Thank you very much for that - that is helpful. I think that I have fixed it on my latest -devel commit.

[MCollett]

I think that I have fixed it on my latest -devel commit.

I've just built the latest version from github, and it still shows the same symptoms.  I thought that the change made to fix it would have done the job, but apparently not.

Best wishes,
Matthew

[jamespetts]

Are you sure that you built the -devel branch rather than -master?

[MCollett]

Are you sure that you built the -devel branch rather than -master?

Yes.  The commit code confirms it (41d9404), and I did check in the source file (gui/pakselector)  to see that the relevant change was there; my first thought had been that some subsequent merge might have undone it. 

Best wishes,
Matthew