The International Simutrans Forum

 

Author Topic: Problem with multi-tile city building generation  (Read 232 times)

0 Members and 1 Guest are viewing this topic.

Offline nrg

  • *
  • Posts: 4
Problem with multi-tile city building generation
« on: September 21, 2020, 08:44:41 AM »
I've created a couple of multi-tile buildings and noticed that all of the buildings created through city growth (including the grow city tool) are only facing south or east.  It doesn't seem to matter what size the building is or where the nearest road is.  The buildings (3x1, 2x3, 3x3, and 4x3) have four directions defined and can be placed manually with no problem, including with the direction set to "auto".

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 20266
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Problem with multi-tile city building generation
« Reply #1 on: September 26, 2020, 10:55:30 PM »
Thank you for your report. It was not me who wrote the multi-tile city building code, so I do not know how this works. Given the amount of time that I have available at present and the long list of pressing Simutrans priorities, and the relatively minor nature of this issue, I am afraid that I will not be able to dedicate time to looking into this in the foreseeable future.

However, if anyone else would like to look into this, that would be very much appreciated.

Offline Ranran

  • Devotee
  • *
  • Posts: 1197
  • Languages: ja
Re: Problem with multi-tile city building generation
« Reply #2 on: September 27, 2020, 05:03:12 AM »
I think extended's multi-tile city building code was different from standard. I don't know how it's different but I haven't seen any major conflicts in this with the ongoing integration work from standards. But I skip commits that are completely separate from the GUI and BUG (and compilability) as much as possible. I hope someone can check it.
If possible, maintenance will be easier if the specifications are the same as the standard. I don't understand if the difference is necessary.

Online prissi

  • Developer
  • Administrator
  • *
  • Posts: 10214
  • Languages: De,EN,JP
Re: Problem with multi-tile city building generation
« Reply #3 on: September 27, 2020, 11:33:20 AM »
Extended incorporated and earlier version of the patch which was broken in some places and did not handle roatable buildings correctly among other issues. (Like no way back to single tile and vice versa.) In the end, I had to rewrite it almost entirely, very little was left of the patch originally (which is the one in extended, as far as I know.)

The standard patch has been tested very much due to pak128.German and pak192.comic both containing multitile rotatable citybuildings. This means that the relevant commits in standard are spread through some revisions, unfortunately. Maybe most easy is to generate a diff between before and current state. (svn diff -r123:HEAD)

Since it just concerns the placing of the buildings, the standard code should work, even with extendend.

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 20266
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Problem with multi-tile city building generation
« Reply #4 on: September 27, 2020, 11:56:12 AM »
Prissi - that is helpful, thank you. This may well be able to be fixed as the merge work goes ahead, especially since the town building code remains mostly unchanged from Standard for now.