The International Simutrans Forum

 

Author Topic: [r7160] Vehicle window is not ready for skin  (Read 2699 times)

0 Members and 1 Guest are viewing this topic.

Offline z9999+

  • Coder/patcher
  • *
  • Posts: 377
[r7160] Vehicle window is not ready for skin
« on: April 22, 2014, 12:04:02 PM »
When I use standard-large.tab theme, some buttons and texts on vehicle window are overlapped each other and are not readable.


Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4602
  • Languages: EN, DE, AT
Re: [r7160] Vehicle window is not ready for skin
« Reply #1 on: April 22, 2014, 02:45:30 PM »
Please retest with r7161.

Offline eipi

  • *
  • Posts: 67
  • Languages: DE EN FR ES C++ LaTeX
Re: [r7160] Vehicle window is not ready for skin
« Reply #2 on: April 22, 2014, 04:34:32 PM »
I've also noticed that when using standard-large.tab, the icons in the main menu bar at the top of the screen change size if you zoom in and out.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4602
  • Languages: EN, DE, AT
Re: [r7160] Vehicle window is not ready for skin
« Reply #3 on: April 22, 2014, 04:50:51 PM »
should be fixed with r7163

Offline eipi

  • *
  • Posts: 67
  • Languages: DE EN FR ES C++ LaTeX
Re: [r7160] Vehicle window is not ready for skin
« Reply #4 on: April 23, 2014, 03:54:10 PM »
Well, the icons are still too small if day/night change is enabled and zoom level is 3.

Offline Yona-TYT ve

  • Devotee
  • *
  • Posts: 1232
    • Simutrans-BLOG
  • Languages: ES
Re: [r7160] Vehicle window is not ready for skin
« Reply #5 on: April 23, 2014, 06:01:26 PM »

A couple of details on the buttons.





Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4602
  • Languages: EN, DE, AT
Re: [r7160] Vehicle window is not ready for skin
« Reply #6 on: April 23, 2014, 06:21:44 PM »
@eipi: should be fixed with r 7166 as well

Offline eipi

  • *
  • Posts: 67
  • Languages: DE EN FR ES C++ LaTeX
Re: [r7160] Vehicle window is not ready for skin
« Reply #7 on: April 24, 2014, 02:46:54 PM »
Seems to be fixed in r7166, thanks! I found another bug, though: If you load a new theme with a different icon size while the game is running, the icons are still broken.
This also happens when day/night change is disabled.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4602
  • Languages: EN, DE, AT
Re: [r7160] Vehicle window is not ready for skin
« Reply #8 on: April 24, 2014, 06:46:40 PM »
Could not reproduce this. The aero theme does not set the icon size, but apart from this nothing wrong.

Offline eipi

  • *
  • Posts: 67
  • Languages: DE EN FR ES C++ LaTeX
Re: [r7160] Vehicle window is not ready for skin
« Reply #9 on: April 24, 2014, 07:36:24 PM »
OK, I learnt something again: Always revert your working copy before posting bug reports . ;) It also works for me now. :D

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4602
  • Languages: EN, DE, AT
Re: [r7160] Vehicle window is not ready for skin
« Reply #10 on: April 24, 2014, 08:14:32 PM »
@YONA-TNT: the halt and convoy info window should be fixed in r 7168.

This is the last fix a do related to this theme stuff. Before doing this theme crap, it would have been much better to get rid of all the absolute positioning and magic pixel counting.