[Patch] CHG: do not close sticky windows when pressing ESC

[koroal]

Currently, the pin icon in window's title bar only prevents it from getting closed when using Backspace to close all windows. In my experience, it is not very intuitive (it took me significant time to figure out what exactly the icon does) nor it is very useful (because one still can accidentally close an important window by hitting Escape when trying to close another window and not noticing that the important window is focused instead).

I suppose, the current implementation has its reasons and was done like that on purpose. Still, I would like to propose at least to consider changing this behavior. In my opinion, that would make the pin functionality more obvious and more useful.

This patch prevents pinned windows from getting closed by Escape. They can still be closed without unpinning by clicking the [X] title bar button, or by right-clicking their corresponding toolbar icon.

[Yona-TYT]

I have always wanted to give a double purpose to that "pin icon", in my opinion it is not very useful.

The double purpose would be to avoid accidental closing (which it already does) and always fix the window to the top so that it is always in sight, that is something that in my opinion would be more useful.  

[koroal]

fix the window to the top so that it is always in sight

That would probably be non-trivial to implement properly (probably from both the UI standpoint and the code standpoint). Though it is hard for me to say anything about the matter as I am quite bad with designing GUIs.

I am not even so sure anymore about the change I have proposed here. After playing the game for a few more days and getting more used to the GUI, I have now started to see how the current implementation may have its advantages. Namely, it allows to close pinned windows more easily when they are no longer needed. In exchange, one needs to be more mindful about using Escape and not to try to use it to clear up the screen quickly (one should probably use Backspace for that) or to cancel the current selected tool (one should use A instead, but I often made such a mistake at first).

In the end, I think this type of change needs to be more carefully thought out first.

[RESTRICTED ACCOUNT]

 

[Yona-TYT]

Actually this is the behavior I'm looking for which is very useful for me:

Once upon a time, the standard had the following arguments:
https://forum.simutrans.com/index.php/topic,20442.msg192234.html ....

Your project is also very interesting, I am very sorry that it was never implemented in standard. 

[RESTRICTED ACCOUNT]

 

[Yona-TYT]

For me it is very useful, for example if I am using a tool and I open multiple windows, it is always good to have that toolbar always in front.

And if the window obstructs the view of another, then one just has to double click on the title bar to minimize.

Maybe it's a matter of adapting and getting used to it, don't you think?.

[RESTRICTED ACCOUNT]