r11155 - built oil rigs

[Andarix]

During the current game, 2 oil rigs were built one inside the other.

[Yona-TYT]

A very nice bug 😊

[prissi]

This should only happen if there is a zero spacing given (in principle) as there is an exclusion map. But maybe this does not work on water.

[ceeac]

r11714 adds a (currently failing) test for this bug.

EDIT: Should be fixed in r11716.

[prissi]

Thank you.

I still wonder, there should be an exclusion area map around each factory. (fab_map) and is_factory_at() should return true in the factory_site_searcher_t(). So I guess either the factory map is not properly updated or there is another issue hidden.

EDIT:
Indeed, the factory exclusion zone was not obeyed for water factories. Also, the factory is_area_ok had an one off error in w and h for checking place size for the actual factory building.